chore: remove get_number_sequence foreign calls
#3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
|
Done, thanks for the reminder. |
TomAFrench
added a commit
that referenced
this pull request
Nov 30, 2023
* master: (216 commits) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) fix: docker builds (#3620) feat: Copy on write optimization for brillig (#3522) chore: separate methods in `dc_crate` into their own modules (#3585) feat: add special case for boolean AND in acir-gen (#3615) chore: Update ACIR artifacts (#3614) chore: remove `get_number_sequence` foreign calls (#3613) feat: Add package version to Nargo.toml metadata (#3427) chore(docs): Links to Aztec docs from errors (#3423) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1911
Summary*
This PR removes the
get_number_sequenceandget_reverse_number_sequenceforeign calls and replaces their usage in tests with a mocked foreign call.I'm leaving this as non-breaking as we make no guarantees about these functions and anyone relying on a foreign call to create an array of increasing numbers... shouldn't.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.